fix(panic): fix panic when censoring utf-8 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stephenduke-care <stephen.duke@care.com>
TwiN
requested changes
Sep 11, 2023
|
My bad, flubbed the PR and accidentally opened a new one here: #64 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#43
Modified indexToRune to correctly count runes up to the given byte index. Adjusted Censor function to handle multi-byte characters properly, ensuring accurate index calculations during the censoring process. Updated incrementation of currentIndex to consider byte length, facilitating correct string iteration.
Checklist
README.md, if applicable.