Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TT-11247] Adds customization for liveness and readiness probes #346

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

vanny96
Copy link
Contributor

@vanny96 vanny96 commented Oct 28, 2024

Description

Allows for customization of livenessProbe and readinessProbe

Related Issue

TykTechnologies/tyk#6674

Motivation and Context

This allows teams to specify custom liveness and readiness probes.
In our team we want for a pod to be considered unhealthy if the response of the /health endpoint is not pass. In order to do that, we need to be able to customise the various probes.

Test Coverage For This Change

Tested trough usage of helm template

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vanny96 vanny96 requested a review from a team as a code owner October 28, 2024 12:33
@vanny96 vanny96 requested review from buraksekili and removed request for a team October 28, 2024 12:33
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vanny96 for the contribution! Overall looks good to me! I just left a minor comment but besides that, looks great.

components/tyk-gateway/values.yaml Outdated Show resolved Hide resolved
@Yubee116 Yubee116 changed the title Adds customization for liveness and readiness probes [TT-11247] Adds customization for liveness and readiness probes Oct 30, 2024
@vanny96 vanny96 requested a review from buraksekili October 31, 2024 08:13
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you @vanny96 for your collaboration and great contribution!
The PR will be tested by our QA team and merged it once the testing process is completed

@bojantyk
Copy link
Contributor

bojantyk commented Nov 5, 2024

hey @vanny96 @buraksekili can we fix lint errors in this PR before we merge it ?

@bojantyk bojantyk merged commit 5d532e6 into TykTechnologies:main Nov 5, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants