Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TT-13461] - Fix mdcb service #352

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[TT-13461] - Fix mdcb service #352

merged 2 commits into from
Nov 5, 2024

Conversation

zalbiraw
Copy link
Member

@zalbiraw zalbiraw commented Oct 31, 2024

Description

Fix MDCB service when set to LoadBalancer Type. The externalTrafficPolicy should be set under spec not selectors.

Related Issue

https://tyktech.atlassian.net/browse/TT-13461

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner October 31, 2024 19:45
@zalbiraw zalbiraw requested review from buraksekili and removed request for a team October 31, 2024 19:45
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @zalbiraw !

@buraksekili buraksekili changed the title Fix mdcb service [TT-13461] - Fix mdcb service Nov 1, 2024
@bojantyk bojantyk merged commit 6b61f42 into main Nov 5, 2024
7 checks passed
@bojantyk bojantyk deleted the zalbiraw-patch-1 branch November 5, 2024 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants