Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TT-13614] Add tests.enabled to values.yaml to allow tests to be turned off #357

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

zalbiraw
Copy link
Member

Description

As a user I would like to turn off the tests pods created through the different charts manifests.

Ultimately I would also like to set labels, annotations, resources, securityContext, etc to adhere to my k8s cluster security policies.

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner November 15, 2024 18:29
@zalbiraw zalbiraw requested review from komalsukhani and removed request for a team November 15, 2024 18:29
@zalbiraw zalbiraw force-pushed the configurable-test-pods branch from 60154f5 to 5b11c7a Compare November 15, 2024 19:17
* Add more config options

* fix tests
@zalbiraw
Copy link
Member Author

Used this, maybe we want to maintain it under Tyk?

https://github.com/zalbiraw/alpine-curl-jq

@zalbiraw zalbiraw changed the title Add tests.enabled to values.yaml to allow tests to be turned off [TT-13613] Add tests.enabled to values.yaml to allow tests to be turned off Nov 20, 2024
@caroltyk caroltyk changed the title [TT-13613] Add tests.enabled to values.yaml to allow tests to be turned off [TT-13614] Add tests.enabled to values.yaml to allow tests to be turned off Nov 25, 2024
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @zalbiraw 🚀 overall lgtm, just left a minor comment

tyk-oss/templates/tests/oss-test.yaml Show resolved Hide resolved
@buraksekili
Copy link
Member

For future reference, --skip-tests flag needs to be used if feasible.
ref: https://helm.sh/docs/helm/helm_template/

@bojantyk bojantyk merged commit c325290 into main Dec 23, 2024
7 checks passed
@bojantyk bojantyk deleted the configurable-test-pods branch December 23, 2024 09:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants