Skip to content

feat: list "start" index and add optional props #1326

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 20, 2024
Merged

feat: list "start" index and add optional props #1326

merged 20 commits into from
Dec 20, 2024

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Dec 15, 2024 •
edited
Loading

Props specific:

  • Implements optional props (props that have undefined as default value)
  • Simplifies some built-in block definitions by migrating the attributes to use propsToAttributes

Numbered list specific:

(migrated from #1311)

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Dec 19, 2024 5:23pm
blocknote-website ✅ Ready (Inspect) Visit Preview Dec 19, 2024 5:23pm

@YousefED YousefED changed the base branch from fix/list-start to main December 16, 2024 13:32
@YousefED YousefED changed the title add optional props list "start" index and add optional props Dec 16, 2024
YousefED
YousefED commented Dec 16, 2024
View reviewed changes
@YousefED YousefED changed the title list "start" index and add optional props feat: list "start" index and add optional props Dec 16, 2024
@areknawo areknawo self-requested a review December 18, 2024 16:39
matthewlipski
matthewlipski reviewed Dec 19, 2024
View reviewed changes
YousefED
YousefED commented Dec 19, 2024
View reviewed changes
Copy link
Collaborator Author

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement!

@matthewlipski matthewlipski merged commit 196d4aa into main Dec 20, 2024
4 checks passed
@mfanselmo mfanselmo mentioned this pull request Jan 7, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthewlipski matthewlipski matthewlipski left review comments

@areknawo areknawo areknawo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

list keyboard shortcut other than "1"
3 participants
@YousefED @areknawo @matthewlipski