Skip to content

Fix #1072 #1085

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 4, 2020
Merged

Fix #1072 #1085

merged 3 commits into from
Aug 4, 2020

Conversation

cspotcode
Copy link
Collaborator

Fix #1072
Ripped directly from @evg656e's C-to-JS port of ParseNodeOptionsEnvVar. Thanks!

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #1085 into master will increase coverage by 0.17%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1085      +/-   ##
==========================================
+ Coverage   75.32%   75.49%   +0.17%     
==========================================
  Files           6        7       +1     
  Lines         624      657      +33     
  Branches      148      148              
==========================================
+ Hits          470      496      +26     
- Misses        100      107       +7     
  Partials       54       54              
Flag Coverage Δ
#node_10 72.15% <ø> (ø)
#node_12_15 72.53% <ø> (ø)
#node_12_16 72.34% <ø> (-0.19%) ⬇️
#node_13 75.19% <78.78%> (+0.19%) ⬆️
#node_14 75.19% <78.78%> (+0.19%) ⬆️
#typescript_2_7 75.03% <78.78%> (+0.19%) ⬆️
#typescript_latest 74.27% <78.78%> (+0.23%) ⬆️
#typescript_next 74.12% <78.78%> (+0.24%) ⬆️
#ubuntu 75.19% <78.78%> (+0.19%) ⬆️
#windows 75.34% <78.78%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dist-raw/node-options.js 78.78% <78.78%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfb75c...c44f76e. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 29, 2020

Coverage Status

Coverage increased (+0.8%) to 83.175% when pulling c44f76e on ab/1072 into 8dfb75c on master.

@cspotcode cspotcode requested a review from blakeembrey July 29, 2020 07:11
@cspotcode cspotcode force-pushed the ab/1072 branch 2 times, most recently from 3534360 to 3c4816c Compare August 4, 2020 22:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM support: can't recognize '--experimental-specifier-resolution' flag passed via NODE_OPTIONS
3 participants