-
-
Notifications
You must be signed in to change notification settings - Fork 540
Added a transpile-only ESM loader (#1101) #1102
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1102 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 7 7
Lines 657 657
Branches 148 148
=======================================
Hits 496 496
Misses 107 107
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Looks good but it'll need tests before being merged, and our package.json will need to be updated. You can probably copy-paste an existing ESM test, but add a deliberate type error to make sure it gets ignored. We also have tests that each entrypoint can be resolved, which will validate the changes to package.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs package.json updates and tests; otherwise looks good.
Fixed ESM tests being executed under node 13.0.0 Fixed error message matching criteria
I have added I also added two tests to verify the loader should behave as expected:
Are there any other needed changes I need to make? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; just a couple questions.
@concision looks great, thanks. It's merged. I need a review of #970 before making our next release, but hopefully we can get that done this weekend. It'll be 9.0.0 |
This resolves the feature request #1101: A new ESM loader equivalent of 'ts-node/register/transpile-only'