Skip to content

Refactor fs (cache/tracing) layer into self-contained API #1518

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 16, 2021

Implements #1161
Supercedes #1261, because I wrote #1261 a long time ago and I'm worried about bugs if I try to grok that code again

@cspotcode cspotcode changed the title Refactor fs cache into discrete component; use it everywhere #1161: Refactor fs (cache/tracing) layer into self-contained API Oct 16, 2021
@cspotcode cspotcode linked an issue Oct 16, 2021 that may be closed by this pull request
@cspotcode cspotcode changed the title #1161: Refactor fs (cache/tracing) layer into self-contained API Refactor fs (cache/tracing) layer into self-contained API Oct 16, 2021
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1518 (ce39b0f) into main (bc03a3e) will decrease coverage by 0.12%.
The diff coverage is 82.05%.

❗ Current head ce39b0f differs from pull request most recent head 56dad2f. Consider uploading reports for the commit 56dad2f to get more accurate results
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/module-type-classifier.ts | 92.00% <ø> (-0.31%) | ⬇️ |
| src/resolver-functions.ts | 82.60% <ø> (ø) | |
| src/diagnostics.ts | 46.15% <46.15%> (ø) | |
| src/fs.ts | 66.66% <66.66%> (ø) | |
| src/index.ts | 79.25% <85.71%> (+1.41%) | ⬆️ |
| dist-raw/node-internal-fs.js | 88.88% <87.50%> (+1.38%) | ⬆️ |
| dist-raw/node-cjs-loader-utils.js | 90.38% <91.66%> (ø) | |
| dist-raw/node-esm-default-get-format.js | 71.42% <100.00%> (ø) | |
| dist-raw/node-package-json-reader.js | 88.88% <100.00%> (ø) | |
| src/configuration.ts | 93.67% <100.00%> (-0.16%) | ⬇️ |
| ... and 8 more | |

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor fs (cache/tracing) layer into self-contained API
1 participant