Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Chinese translations #2776

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

XeroAlpha
Copy link
Contributor

I will regularly submit PRs to update the Chinese translations, so there is no need to mention this PR in the changelog when the submitted translations correspond to the original text added in the current version.

Additionally, should this line be tempRefl = tempRefl.parent!;? Since refl and refl.parent keep unchanged inside the while scope.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 17, 2024

Thanks!

I will regularly submit PRs to update the Chinese translations, so there is no need to mention this PR in the changelog when the submitted translations correspond to the original text added in the current version.

I do want to recognize your contributions, so will at least continue adding a thanks line :)

Additionally, should this line be tempRefl = tempRefl.parent!;? Since refl and refl.parent keep unchanged inside the while scope.

Good catch! Yes, it absolutely should be

@Gerrit0 Gerrit0 merged commit 55632bd into TypeStrong:beta Nov 17, 2024
5 checks passed
@Gerrit0 Gerrit0 mentioned this pull request Nov 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants