Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix ssh into windows #19

Merged
merged 5 commits into from
Jun 8, 2020
Merged

fix ssh into windows #19

merged 5 commits into from
Jun 8, 2020

Conversation

ricardosantos9521
Copy link
Contributor

@ricardosantos9521 ricardosantos9521 commented Jun 8, 2020 •
edited
Loading

  • Fix regex expression that was trying to detect if uri.path was a windows path.
  • use resolveSSHHostName to detect username if needed in windows remotes too
  • convert uri.path to a windows path

@ricardosantos9521 ricardosantos9521 changed the title fix ssh in windows fix ssh into windows Jun 8, 2020
Tyriar
Tyriar requested changes Jun 8, 2020
View reviewed changes
Tyriar
Tyriar approved these changes Jun 8, 2020
View reviewed changes
Copy link
Owner

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@Tyriar Tyriar merged commit 5dbb039 into Tyriar:master Jun 8, 2020
@ricardosantos9521 ricardosantos9521 deleted the dev/fix-ssh-remote-windows branch June 8, 2020 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardosantos9521 @Tyriar