Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add setting to reuse an existing terminal window #37

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

Joinyy
Copy link
Contributor

@Joinyy Joinyy commented Aug 14, 2021

This should fix #35 👍

I just added a new boolean setting reuseExistingWindow that will insert the needed arguments into the args array and thus works for all profiles. I could only test it with the stuff that is available on my windows machine but I do not see where else it would not work, as the command line arguments are available on all platforms equally.

Copy link
Owner

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, this works great! I switched the default to true, will release soon 🙂

@Tyriar Tyriar merged commit dce6d91 into Tyriar:master Oct 21, 2021
@Joinyy Joinyy deleted the dev/reuse-terminal-option branch October 22, 2021 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse already opened terminal
2 participants