Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prefix features should also end up on their own lines #373

Closed
aarppe opened this issue Mar 28, 2020 · 4 comments · Fixed by #464
Closed

Prefix features should also end up on their own lines #373

aarppe opened this issue Mar 28, 2020 · 4 comments · Fixed by #464
Assignees
Labels
bug Something isn't working, as it should and/or according to specs requires-frontend-work Work needs to be done on HTML, CSS, and/or JavaScript

Comments

@aarppe
Copy link
Contributor

aarppe commented Mar 28, 2020

When searching with a Cree word like ê-kî-nitawi-kâh-kîmôci-kotiskâwêyâhk, with preverbs (PV/...+) and reduplication elements (RdplW+ and RdplS+), the preverbs currently do nt end up on their own line, in contrast to the suffix features:

image

So, the visual presentation should be updated so that also prefixal features in the pop-up are shown each on their own line. In the above screenshot, that is NOT yet the case for the preverbs - they should appear similar to the suffix features, each on their own line.

@aarppe aarppe added the bug Something isn't working, as it should and/or according to specs label Mar 28, 2020
@aarppe
Copy link
Contributor Author

aarppe commented Mar 28, 2020

@kobexamoh This fix is for you.

@kobexamoh kobexamoh self-assigned this Mar 28, 2020
@eddieantonio
Copy link
Member

eddieantonio commented Mar 30, 2020

@aarppe, does this screenshot demonstrate the issue you're talking about? It seems to me that you're talking about the linguistic breakdown, which is not visible in this screenshot.

@aarppe
Copy link
Contributor Author

aarppe commented Mar 30, 2020

I've fixed the screenshot above, which illustrates the current undesired state of affairs, where the presentation of prefixal features (preverbs and reduplication, and initial change) is NOT YET correct - they should appear similar to the suffix features, each on their own line.

@eddieantonio eddieantonio added the requires-frontend-work Work needs to be done on HTML, CSS, and/or JavaScript label Jun 10, 2020
@kobexamoh kobexamoh removed their assignment Jun 15, 2020
@eddieantonio eddieantonio self-assigned this Jun 17, 2020
@eddieantonio
Copy link
Member

Blocked by #462 — it will cause a merge conflict if I try to fix this simultaneously :/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working, as it should and/or according to specs requires-frontend-work Work needs to be done on HTML, CSS, and/or JavaScript
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants