Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce warnings #1281

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Reduce warnings #1281

merged 4 commits into from
Oct 26, 2023

Conversation

KrisThielemans
Copy link
Collaborator

No description provided.

- make warning on too small num_tangential_LORs clearer
- remove warning on too large voxel-size for backprojection, as the matrix
will always give artefacts for backprojecting (unless using many many LORs)
in Debug mode ProjData.read_from_file was writing warnings about which file
format was going to be used. These are now converted to info() calls
at verbosity-level 3.

Also cleaned up some old-style calls to error().
The `set_up()` method now skips further processing if it was already called
with data of the same characteristics. This will means that any cached data
will be re-used, potentially leading to a speed-up when re-using it from Python.
we cannot do this yet, but the error was confusing.

also minor code clean-up
@KrisThielemans KrisThielemans added this to the v5.2 milestone Oct 26, 2023
@KrisThielemans KrisThielemans merged commit ca3c23a into UCL:master Oct 26, 2023
@KrisThielemans KrisThielemans deleted the reduceWarnings branch October 26, 2023 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant