Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Choice of quantitative information in readSCPfromDIANN function #23

Closed
KristinaGomoryova opened this issue Jun 20, 2023 · 1 comment
Closed

Comments

@KristinaGomoryova
Copy link

Hello,

would you consider adding a new argument to the readSCPfromDIANN function, where user could choose which column containing quantitative information (e.g. PG.Quantity, PG.Normalised or PG.MaxLFQ) will be used? Currently it seems to be using MS1.Area column by default - and when analyzing DIA data, I would prefer actually using different one, e.g. PG.Quantity.

Thanks a lot for considering!

@cvanderaa
Copy link
Member

Hello @KristinaGomoryova!

You are right, up to now only the Ms1.Area column is considered when fetching the quantitative info. I think it is about time to move readSCPfromDIANN from this repo to the scp package. In the scp package, I added an argument to the function so you can select another column.

I created a new issue in the scp package: UCLouvain-CBIO/scp#42. I suggest we move the discussion to that issue and I will close this one.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants