Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: function to create a QFeatures object from DIANN output #42

Closed
3 tasks
cvanderaa opened this issue Jun 22, 2023 · 3 comments
Closed
3 tasks

feat: function to create a QFeatures object from DIANN output #42

cvanderaa opened this issue Jun 22, 2023 · 3 comments

Comments

@cvanderaa
Copy link
Member

I moved readSCPfromDIANN() from the SCP.replication repo to the scp packages.

Upon request (see UCLouvain-CBIO/SCP.replication#23), I also added an argument ecol to select the column that contains the quantitative information.

I still need to perform the following tasks before considering this issue solved:

  • Comprehensive unit testing
  • Improve documentation: add examples
  • Refactor: the code is too long and difficult to understand
@cvanderaa
Copy link
Member Author

cvanderaa commented Jun 22, 2023

@KristinaGomoryova, you can play with the new argument after installing the development version of scp:

BiocManager::install(UCLouvain-CBIO/scp)
library(scp)
?readSCPfromDIANN

@KristinaGomoryova
Copy link

Thanks a lot, I'll try it right away!

@cvanderaa
Copy link
Member Author

This issue is now solved in QFeatures since rformassspectrometry/QFeatures@c895bbc and propagated to scp since bca8162

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants