fix: fixed small error in degrees of freedom

UCLouvain-CBIO · Apr 24, 2024 · 352c5e3 · 352c5e3
1 parent 6a39bb3
commit 352c5e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,8 +1,9 @@
 # scp 1.13
 
-## scp 1.13.5 
+## scp 1.13.5
 
-(nothing yet)
+- fix: fixed small error in degrees of freedom
+- fix: break workflow upon infinite values
 
 ## scp 1.13.4
 

diff --git a/R/ScpModel-Workflow.R b/R/ScpModel-Workflow.R
@@ -332,7 +332,8 @@ scpModelWorkflow <- function(object, formula,
         hat <- x %*% tcrossprod(xtxInvLam, x)
         df <- length(y) - sum(diag(2 * hat - tcrossprod(hat)))
     } else {
-        df <- max(length(y) - ncol(x) - 1, 1)
+        ## note: not - 1 because intercept is in x
+        df <- max(length(y) - ncol(x), 1)
     }
     residuals <- y - x %*% beta
     list(coefficients = beta[, 1],