Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(FN-3163): remove local ssl workaround #1188

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

natdeanlewissoftwire
Copy link
Contributor

@natdeanlewissoftwire natdeanlewissoftwire commented Jan 30, 2025

Introduction ✏️

On local builds, the Salesforce domains needed to create a customer are not whitelisted on the UKEF VPN, so rejectUnauthorized must be set as false. This doesn't affect higher environments.

Resolution ✔️

Remove this setting so local builds will fail, but will replicate the code running on higher environments more closely.

Miscellaneous ➕

Remove the same commented-out behaviour from Informatica, this domain IS whitelisted so works on local builds regardless.

@natdeanlewissoftwire natdeanlewissoftwire marked this pull request as ready for review January 30, 2025 17:34
@abhi-markan abhi-markan merged commit f65b047 into main Jan 30, 2025
33 checks passed
@abhi-markan abhi-markan deleted the feat/FN-3163/remove-local-ssl-workaround branch January 30, 2025 17:57
abhi-markan added a commit that referenced this pull request Feb 2, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.25.0](v1.24.0...v1.25.0)
(2025-02-02)


### Features

* **FN-3163:** remove local ssl workaround
([#1188](#1188))
([f65b047](f65b047))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants