Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

improve(common): Change Optimism average block time to 2s #4573

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve(common): Change Optimism average block time to 2s #4573

wants to merge 3 commits into from
+5 −2

Conversation

nicholaspai
Copy link
Member

nicholaspai added a commit to across-protocol/relayer that referenced this pull request Jun 12, 2023
@nicholaspai
improve: Clean up Constants file
6540059 
# Motivation

Optimism Bedrock upgrade means that we should change some assumptions about how Optimism blocks work. I also used the opportunity to clean up the constants file and update the average Optimism block time assumption in this PR

UMAprotocol/protocol#4573
mrice32
mrice32 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@mrice32 mrice32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Looks like there may be a test that depends on this timing :(

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mrice32 mrice32 mrice32 approved these changes

@md0x md0x md0x approved these changes

@chrismaree chrismaree Awaiting requested review from chrismaree chrismaree is a code owner

@Reinis-FRP Reinis-FRP Awaiting requested review from Reinis-FRP Reinis-FRP is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaspai @mrice32 @md0x