fix: add csp settings #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupl
reviewed
Nov 7, 2022
| @@ -175,14 +176,18 @@ module.exports = { | |||
| // Google reCAPTCHA v2: scripts to load UI. See frameSrc. | |||
| 'https://www.google.com', | |||
| 'https://www.gstatic.com', | |||
| 'www.googletagmanager.com', | |||
| // These hashes are for GA and our inline JS+feature detection. | |||
There was a problem hiding this comment.
My browser requested that another SHA be added to allow GTM inline script to execute:
Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' https://www.google-analytics.com data: https://www.google.com https://www.gstatic.com www.googletagmanager.com 'sha256-zITkoAg4eI1v3VSFI+ATEQKWvoymQcxmFNojptzmlNw=' 'sha256-Ch69wX3la/uD7qfUZRHgam3hofEvI6fesgFgtvG9rTM=' 'nonce-07d68ed120e378e0c1566480028c2145'". Either the 'unsafe-inline' keyword, a hash ('sha256-g62AIFyyvfvqRMhNu7QMQ0GMk0Rx+Bbk1KzTy+CzTCI=')
The hash is the convention we've been using so I'll make a follow-up PR to include it.
rupl
added a commit
that referenced
this pull request
Nov 7, 2022
rupl
added a commit
that referenced
this pull request
Nov 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: HID-2354
This adds CSP exceptions we include in the Drupal sites - but not the 'unsafe-inline' exception - which may be covered by the hash which is included already. Needs testing.