Fixed --files argument to sort alphabetically #1
Conversation
src/cli_utils.rs
Outdated
| @@ -337,14 +337,16 @@ impl<W: Write> Printer<W> { | |||
|
|
|||
| if self.list_files { | |||
| self.print_subrow()?; | |||
|
|
|||
| let mut reports: Vec<_> = language.reports.clone(); | |||
There was a problem hiding this comment.
Because "language" is borrowed and sort_by function requires mutable access.
There was a problem hiding this comment.
You could create a new Vec<&R> from language.reports which stores the data type R and sort that one. You can use .map and .collect.
There was a problem hiding this comment.
I don't know if this is how I should do it, if I try like this to get a Vec , it says that the Copy Trait is not implemented.
And I can't use a Vec<&Report> because I would have to change the code below to accept &Report
let (a, b): (Vec<_>, Vec<_>) = reports .iter() .partition(|r| r.stats.blobs.is_empty());
There was a problem hiding this comment.
Please use
post code hereto post code instead of pictures.
There was a problem hiding this comment.
You want to get a Vec<&Report>, instead you are trying to take ownership here.
There was a problem hiding this comment.
Pushed a commit now with the requested change. I will run fmt on it after feedback,
No, I didn't.
|
You might need to install the |
|
Looks good, please send it to upstream and place a link to it here. |
Now if
--filesargument is found it will sort by default alphabetically the name of the files. If--sortargument is also provided (for exampletokei --files --sort blanks), the sorting for files will be ignored and it will only sort by given argument.Before:
After:
Should fix XAMPPRocky#1053