enhancement/cwms-timeseries-list #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: USACE/instrumentation#210
Implement
useInfiniteQueryas well asuseInfiniteScrollhook to manage infinite scrolling on the CWMS Timeseries List. Set new page size limit of 500 to address large payloads taking a long time to request across network as well as long render times.Also integrated with the
likequery param in the CWMS API. This will further reduce the size of the returned payloads. User input is debounced by 300ms to reduce the number of requests sent to the CWMS API.Fixed an issue that was causing the
buildQueryParamsfunction to attempt to pass empty strings as query params unintentionally.