Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add precision to logfile proces timing #182

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

bnmurphy
Copy link
Contributor

@bnmurphy bnmurphy commented Dec 1, 2022

Contact:
Ben Murphy, US EPA

Type of code change:
Minor formatting change

Description and/or issue being addressed: At high computational efficiency, the default precision provided for the timing metrics in the logfile was yielding 0.0. When aggregated, this underestimated the time taken by these processes. This PR adds 3 decimal places of precision to the timing output.

Impact on results: None

Tests conducted:
Ran on the NE Benchmark 2018 case for intel, gnu, and pgi in optimized and debug mode.

 On branch logfile_precision
	modified:   CCTM/src/util/util/RUNTIME_VARS.F
@bnmurphy bnmurphy requested a review from lizadams December 1, 2022 11:29
@lizadams
Copy link
Contributor

lizadams commented Dec 1, 2022

@bnmurphy
It looks like we had also edited a format statement in sciproc.F when we implemented our fix.

diff BLD_CCTM_v533_gcc_precision/sciproc.F BLD_CCTM_v533_gcc/sciproc.F

323c323

< 1002 FORMAT ( 2x, A15, ' completed... ', F6.3, ' seconds' )


1002 FORMAT ( 2x, A15, ' completed... ', F6.1, ' seconds' )


! Print Summary Timing for Master time step      

      CALL TIMING_SPLIT ( CPU_TIME_START_MASTER, 2 )



1002  FORMAT ( 2x, A15, ' completed... ', F6.3, ' seconds' )

You may want to set the format to be F12.3 to be consistent with changes to RUNTIME_VARS.F

@bnmurphy
Copy link
Contributor Author

bnmurphy commented Dec 1, 2022

Thanks @lizadams! Done.

Copy link
Contributor

@lizadams lizadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@lizadams
Copy link
Contributor

lizadams commented Dec 2, 2022

Confirmed that the timing output is improved with the additional significant figures in the reporting.
Processing completed... 1.0826 seconds
VDIFF completed... 0.7591 seconds
COUPLE completed... 0.0086 seconds
HADV completed... 0.1355 seconds
ZADV completed... 0.0229 seconds
HDIFF completed... 0.0402 seconds
DECOUPLE completed... 0.0035 seconds
PHOT completed... 0.1413 seconds
CLDPROC completed... 0.1169 seconds
CHEM completed... 0.1647 seconds
AERO completed... 0.1907 seconds
Processing completed... 1.5839 seconds
=--> Data Output completed... 0.5029 seconds

@kmfoley kmfoley merged commit 340fe5d into USEPA:5.4+ Dec 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants