Filter extremely small p-values by setting them to Machine$double.xmin #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a helper function that calls pchisq and then filters any p-values that are smaller than Machine$double.xmin to the double.xmin value.
mconomos
reviewed
Mar 20, 2024
pchisq behaves a little differently for df=0 than for df>0, and you can legitimately get pval=0 when df=0. We don't want to set those zeros to the double.xmin value. Also update the test to use expect_identical instead of expect_equal, which checks within a tolerance.
Include testing with lower.tail=TRUE
Not needed; the previous call to pchisq should handle it if the user doesn't include df as an argument.
mconomos
reviewed
Mar 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any p-values calculated by pchisq, set any p-values smaller than Machine$double.xmin to the double.xmin value. This should help prevent pval=0 cases.
Closes #111