up node to 4.4 LTS on shippable/travis #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! Agree it's pretty preposterous we've been on 0.10 all this time. Since our Shippable config has been busted for so long, I'm not so worried about that. Would you mind submitting a PR for uproxy/uproxy too? 👍 |
|
Will do, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See UWNetworksLab/uProxy-p2p#2396 for background.
Tests still pass (on Travis - Shippable is disabled at the moment), so this could be fine to just merge as is. However if you want me to look into dealing with the C++11 error message (switching to Trusty, or trying those other config parameters), let me know. Thanks!
This change is