Add space after url in error message #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes UmbrellaDocs#31 Github will parse the trailing comma as part of the url when the warning appears in a github action log, so the link cannot be followed. Arguably this is a github bug, and not a linkspector bug, because github does not include the comma in the URL in other places, like in issues. Nevertheless, linkspector will probably be running in github actions quite often, so it would be good if the links are clickable from there without having to manually remove the comma.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
Github will parse the trailing comma as part of the url when the warning appears in a github action log, so the link cannot be followed.
Arguably this is a github bug, and not a linkspector bug, because github does not include the comma in the URL in other places, like in issues.
Nevertheless, linkspector will probably be running in github actions quite often, so it would be good if the links are clickable from there without having to manually remove the comma.