Fixes issue 39 #54
Merged
Fixes issue 39 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 39 #39 It's a scope issue caused by rendering the fields in a loop resulting in the last field rendered to always be the one processed when any form submits. This solution breaks the rendering into a separate function and then just call that function in the loop.
UndefinedOffset
requested changes
Aug 30, 2019
|
Thanks for the pull, just one change can you replace the uses of |
|
Have updated with var instead of let as requested. Let me know if you have further suggestions. |
|
All good, I’ll do a tag next week :), thanks! |
matthewrayner
pushed a commit
to timezoneone/silverstripe-nocaptcha
that referenced
this pull request
Apr 26, 2023
* Fixes issue 39 Fixes issue 39 UndefinedOffset#39 It's a scope issue caused by rendering the fields in a loop resulting in the last field rendered to always be the one processed when any form submits. This solution breaks the rendering into a separate function and then just call that function in the loop. * Replace let with var for compatibility (cherry picked from commit aa12ec3)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 39 #39
It's a scope issue caused by rendering the fields in a loop resulting in the last field rendered to always be the one processed when any form submits. This solution breaks the rendering into a separate function and then just call that function in the loop.