Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow developers to handle form submission separately. #76

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Allow developers to handle form submission separately. #76

merged 1 commit into from
Dec 13, 2021

Conversation

GuySartorelli
Copy link
Contributor

Fixes #75 and #67

@GuySartorelli
Copy link
Contributor Author

Note that technically v2 doesn't need the new nocaptcha_handleCaptcha function - but I have included it for consistency's sake. Developers should be able to swap between v2 and v3 without altering their own scripts.

UndefinedOffset
UndefinedOffset requested changes Dec 10, 2021
View reviewed changes
Copy link
Owner

@UndefinedOffset UndefinedOffset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes otherwise looks good, thanks :)

@GuySartorelli
Copy link
Contributor Author

@UndefinedOffset I've made the requested changes.

@UndefinedOffset UndefinedOffset merged commit 1debfa7 into UndefinedOffset:master Dec 13, 2021
@UndefinedOffset
Copy link
Owner

Thanks! tagged as 2.3.0

@GuySartorelli GuySartorelli deleted the feat/allow-custom-submit-handlers branch December 13, 2021 19:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@UndefinedOffset UndefinedOffset UndefinedOffset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make javascript optional
2 participants
@GuySartorelli @UndefinedOffset