4.6.0 fails to build on big-endian architectures: undefined reference to `byteswap8'

[sebastic]

NetCDF 4.6.0 fails to build on big-endian architectures:

[ 30%] Linking C executable ncgen3
cd /<<PKGBUILDDIR>>/obj-mips-linux-gnu/ncgen3 && /usr/bin/cmake -E cmake_link_script CMakeFiles/ncgen3.dir/link.txt --verbose=1
/usr/bin/cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Wl,-z,relro -Wl,-z,now CMakeFiles/ncgen3.dir/main.c.o CMakeFiles/ncgen3.dir/load.c.o CMakeFiles/ncgen3.dir/escapes.c.o CMakeFiles/ncgen3.dir/getfill.c.o CMakeFiles/ncgen3.dir/init.c.o CMakeFiles/ncgen3.dir/genlib.c.o CMakeFiles/ncgen3.dir/ncgentab.c.o  -o ncgen3 -Wl,-rpath,/<<PKGBUILDDIR>>/obj-mips-linux-gnu/liblib:/usr/lib/mips-linux-gnu/hdf5/serial: ../liblib/libnetcdf.so.13 /usr/lib/mips-linux-gnu/hdf5/serial/libhdf5_hl.so /usr/lib/mips-linux-gnu/hdf5/serial/libhdf5.so -lpthread /usr/lib/mips-linux-gnu/libsz.so /usr/lib/mips-linux-gnu/libz.so /usr/lib/mips-linux-gnu/libdl.so /usr/lib/mips-linux-gnu/libm.so /usr/lib/mips-linux-gnu/libcurl.so 
../liblib/libnetcdf.so.13: undefined reference to `byteswap8'
collect2: error: ld returned 1 exit status

Buildlogs: mips, s390x

[DennisHeimbigner]

Unfortunately, we do not have a big-endian machine against which to test.
So things like this can slip thru. I will create a fix, but you may have
to test it out for me.

[DennisHeimbigner]

P.S. there is also a known bug when using dap4 on a big-endian machine.

[sebastic]

This patch fixes the issue on the s390x porterbox:

--- a/libdispatch/dfilter.c
+++ b/libdispatch/dfilter.c
@@ -156,7 +156,7 @@ NC_parsefilterspec(const char* spec, uns
            /* convert to network byte order */
            memcpy(mem,&val64u,sizeof(mem));
 #ifdef WORDS_BIGENDIAN     
-           byteswap8(mem);  /* convert big endian to little endian */
+           NC_byteswap8(mem);  /* convert big endian to little endian */
 #endif
            vector = (unsigned int*)mem;
            ulist[nparams++] = vector[0];

[DennisHeimbigner]

Ok, that is the same fix I was going to ask you to test. So I will just go ahead
and turn it into a pull request.

[t-b]

I could compile latest master on mips successfully, so I guess this can be closed.

[DennisHeimbigner]

Did make check work also?

[t-b]

@DennisHeimbigner Your are too fast ;) Nope, see #1278.