Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hdf5set_format_compatibility.c: Update new function documentation. #2209

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

Dave-Allured
Copy link
Contributor

  • Comment change only. Add one paragraph. Explain the reason for the third argument to H5Pset_libver_bounds. Simplifies experimental code using advanced features.

This updates the original function added in PR #2176.

Comment change only.  Add one paragraph.  Explain the reason for the third argument to H5Pset_libver_bounds.  Simplifies experimental code using advanced features.
@Dave-Allured Dave-Allured requested a review from WardF as a code owner February 1, 2022 17:09
@WardF
Copy link
Member

WardF commented Feb 1, 2022

I am a bit puzzled how this is failing the checks given the nature of the change. Testing by hand to try to shed some light on it.

@WardF WardF self-assigned this Feb 1, 2022
@WardF WardF added this to the 4.9.0 milestone Feb 1, 2022
@Dave-Allured
Copy link
Contributor Author

I have been noticing random CI failures here and there, for several days. In the single reported failure above, in the CI logs, I saw two timeouts during test suite execution, and nothing else I think.

I think these are probably CI problems unrelated to this PR. You must admit that the simple change in this PR is unlikely to cause any code execution problems.

@Dave-Allured
Copy link
Contributor Author

Um, make that three timeouts. It appears that test no. 87, nc_test_run_mmap, may not be reporting its results properly. The fail was in the log, but not in the fail summary at the end.

@WardF WardF merged commit 46149b2 into Unidata:main Feb 2, 2022
@WardF
Copy link
Member

WardF commented Feb 2, 2022

@Dave-Allured Yeah, I'll take a look at this tomorrow and make sure it's something in the back-end infrastructure and isn't the result of something on our end that I'll need to track down/correct.

@Dave-Allured Dave-Allured deleted the format-compat-function-doc branch February 2, 2022 00:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants