Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make ncZarr-specific deps and options dependent on ncZarr being enabled. #2793

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Make ncZarr-specific deps and options dependent on ncZarr being enabled. #2793

merged 1 commit into from
Nov 7, 2023

Conversation

WardF
Copy link
Member

@WardF WardF commented Nov 7, 2023

Added fenceposts so that dependencies and options specific to nczarr are skipped if nczarr is not enabled.

@WardF WardF added this to the 4.9.3 milestone Nov 7, 2023
@WardF WardF self-assigned this Nov 7, 2023
@DennisHeimbigner
Copy link
Collaborator

I am confused. Are we talking about libzip or zlib?

@WardF
Copy link
Member Author

WardF commented Nov 7, 2023

I'll update so that this only works if HDF5/netCDF4 is turned off altogether as well, not just nczarr.

@WardF
Copy link
Member Author

WardF commented Nov 7, 2023

@DennisHeimbigner libzip, not zlib.

@WardF
Copy link
Member Author

WardF commented Nov 7, 2023

I need to refresh my memory as to what functionality is served by libz vs. libzip; I know libzip is used by ncZarr functionality, but I've now confused myself as to where libz enters in; stepping away for a moment and will come back with fresh eyes.

@WardF
Copy link
Member Author

WardF commented Nov 7, 2023

The diff presented through the GitHub interface is hard to parse visually; I basically moved the if nczarr is turned off check up a couple of lines, replaced the "fi" with an "else", and moved the "fi" below all the 'ncZarr is turned on'-related logic.

@WardF WardF merged commit dd0aedc into Unidata:main Nov 7, 2023
@WardF WardF deleted the fix_nczarr_libzip_dep.wif branch November 7, 2023 21:47
@chenrui333 chenrui333 mentioned this pull request Feb 10, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

Configure netcdf-4.9.2 without libzip
2 participants
@WardF @DennisHeimbigner