Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Properly handle missing regions in URLS #2819

Merged
merged 45 commits into from
Mar 5, 2024
Merged

Properly handle missing regions in URLS #2819

merged 45 commits into from
Mar 5, 2024

Conversation

DennisHeimbigner
Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner commented Dec 3, 2023 •
edited by WardF
Loading

NOTE: it is important that this fix gets into 4.9.3

re: Issue #2798

Modifications

  • Support the following AWS environment variables in the internal S3 library (they are already supported by aws-sdk-cpp).
  • Support an empty region when specifying s3.amazonaws.com as the host.
  • Move some S3/AWS related functions to ds3util.c
  • Add a test case to test empty region and AWS_[DEFAULT]_REGION.

@DennisHeimbigner
test1
c671b97
@DennisHeimbigner
ckp
0088810
@DennisHeimbigner
test1
1341c5f
@DennisHeimbigner
ckp
ec3a7a7
@DennisHeimbigner
Merge branch 'fixes.tmp' into awsdfalt.tmp
c9e9517
@DennisHeimbigner
byte
a525345
@DennisHeimbigner
Merge branch 'awsdfalt.tmp' of https://github.com/DennisHeimbigner/ne…
40269f8 
…tcdf-c into awsdfalt.tmp
@DennisHeimbigner
test5
93bbda6
@DennisHeimbigner
switch
ea7feab
@DennisHeimbigner
ckp
69ad619
@DennisHeimbigner
test1
3b8ed26
@DennisHeimbigner
Merge branch 'awsdfalt.tmp' of https://github.com/DennisHeimbigner/ne…
47db31d 
…tcdf-c into awsdfalt.tmp
@DennisHeimbigner
test10
d6fae81
@DennisHeimbigner
final
ccf35e4
@DennisHeimbigner
unthrow
d81d95a
@DennisHeimbigner
Properly handle missing regions in URLS
27f615b 
NOTE: it is important that this fix gets into 4.9.3

re: Issue Unidata#2798

## Modifications
* This PR includes PR Unidata#2813
* Support the following AWS environment variables in the internal S3 library
  (they are already supported by aws-sdk-cpp).
  - AWS_REGION
  - AWS_DEFAULT_REGION
  - AWS_ACCESS_KEY_ID
  - AWS_CONFIG_FILE
  - AWS_PROFILE
  - AWS_SECRET_ACCESS_KEY
  - (source https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html).
* Support an empty region when specifying s3.amazonaws.com as the host.
* Move some S3/AWS related functions to ds3util.c
* Add a test case to test empty region and AWS_[DEFAULT]_REGION.
@WardF WardF self-assigned this Dec 11, 2023
@WardF WardF mentioned this pull request Dec 11, 2023
Closed
@DennisHeimbigner DennisHeimbigner marked this pull request as draft December 12, 2023 21:11
@DennisHeimbigner DennisHeimbigner marked this pull request as ready for review December 16, 2023 19:58
@WardF WardF added this to the 4.9.3 milestone Mar 5, 2024
@WardF
Copy link
Member

WardF commented Mar 5, 2024

Reviewing to merge, and then #2847

@WardF WardF merged commit 6bcfb4b into Unidata:main Mar 5, 2024
103 checks passed
@DennisHeimbigner DennisHeimbigner deleted the awsdfalt.dmh branch August 14, 2024 02:16
@chenrui333 chenrui333 mentioned this pull request Feb 10, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@WardF WardF WardF approved these changes

Assignees

@DennisHeimbigner DennisHeimbigner

Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

Byte range fails on GOES 16 URL present in tst_byterange.c
2 participants
@DennisHeimbigner @WardF