Convert the ENABLE_XXX options to NETCDF_ENABLE_XXX options for NCZarr #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Primary Change In order to conform to the cmake overhaul, occurrences of ENABLE_XXX options in the nczarr code have been changed to NETCDF_ENABLE_XXX. # Misc. Other changes * Fix use of rand_s in libdispatch/ncrandom.c * Fix some bugs in the mingw gitub action. * Fix signature bug in libncpoco/cp_win32.c * Make some NCZarr fixes to config.h.cmake.in
WardF
approved these changes
May 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary Change
In order to conform to the cmake overhaul, occurrences of ENABLE_XXX options in the nczarr code have been changed to NETCDF_ENABLE_XXX.
Misc. Other changes