Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Give config.h a higher precedence. #3100

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

drwells
Copy link
Contributor

@drwells drwells commented Feb 24, 2025

This fixes a bug on 4.9.2 where an installed non-netcdf config.h (I think this was pulled in from a system library - unfortunately I don't have access to that machine myself) was included instead of netcdf's config.h due to the order of -I statements.

Another nice effect of this is it makes the order of -Is for cmake more similar to those generated by ./configure.

This fixes a bug on 4.9.2 where an installed non-netcdf config.h was
included instead of netcdf's config.h.
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

@drwells drwells changed the title Give config.h a higher precedence. Give config.h a higher precedence. Feb 24, 2025
@WardF
Copy link
Member

WardF commented Feb 24, 2025

This looks great, thank you!

@WardF WardF merged commit 9e86fcb into Unidata:main Feb 24, 2025
107 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants