-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
changed macro STREQ to NCSTREQ to avoid name collusion with HDF4 library #967
changed macro STREQ to NCSTREQ to avoid name collusion with HDF4 library #967
Conversation
Ncgen should be relatively insensitive to flex+bison version as long |
@DennisHeimbigner yes, I get that ncgen should not be dependent on the versions of the tools. I just wanted to point out the changes since a bunch of the autogenerated files do have changes that have nothing to do with the STREQ macro, but are just changes coming from new versions of the tools. @WardF it still makes sense to merge PR #558 before this PR, since both are changing the same generated files. Once #558 is merged, I can update this PR, and regenerate the files, to ensure we have a correct and consistent set of generated code files. |
One test failed due to travis timeout. |
OK, this us up to date with latest merges and Dennis' latest work, and can be merged at any time. |
I will take this down and put it back up after some more important PRs get merged. |
Thanks! |
Fixes #834.
Since the same macro is used in ncgen, I changed it there as well. This required regeneration of the built files in the ncgen directory with make makeparser. Since my version of flex/bison is more new than those used to generate the files last time, there are some changes in the generated files.
FYI:
(This PR also include Fixes #959 in order to pass my CI system.)