Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

const return values #41

Open
bartvstratum opened this issue Oct 17, 2016 · 5 comments
Open

const return values #41

bartvstratum opened this issue Oct 17, 2016 · 5 comments
Assignees
@WardF
Labels
area/build/all type/enhancement
Milestone
4.3.2

Comments

@bartvstratum
Copy link

bartvstratum commented Oct 17, 2016 •
edited
Loading

With Intel 17.0.0, I'm getting warnings like:

ncDim.h(47): warning #858: type qualifier on return type is meaningless
const int getId() const {return myId;};

for every include of <netcdf>. Is there any reason why a const int is returned instead of a int?
@DennisHeimbigner
Copy link
Collaborator

The compiler is correct. The const qualifier is only
meaningful on pointers or structs. Primitive types
like int char float are immutable by nature.

@bartvstratum
Copy link
Author

Are there any plans to fix this? I hate unnecessary warnings as they tend to hide other more important problems/warnings.

@WardF
Copy link
Member

WardF commented Dec 2, 2016

I can't test a fix for Intel because I don't have access to the intel compiler but it seems straight-forward. I'll make the change (most likely early next week) and hopefully that will fix things!

-Ward

@bartvstratum
Copy link
Author

Great, thanks in advance. Let me know if I can test anything with Intel.

@WardF WardF added this to the 4.3.1 milestone Dec 6, 2016
@WardF WardF self-assigned this Dec 6, 2016
WardF added a commit that referenced this issue Dec 6, 2016
@WardF
Updated release notes for #41
189194e
@WardF
Copy link
Member

WardF commented Dec 6, 2016

I've updated the header file and code; let me know if I've missed something, otherwise I'll close this out shortly. You can test using the master branch, and I will being preparing the 4.3.1 release for sometime in the near future.

@WardF WardF modified the milestones: 4.3.1, 4.3.2 Sep 13, 2019
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 3, 2023
(devel/netcdf-cxx) Updated 4.2 to 4.3.1
efb12c3 
\Brief Release notes file for the netcdf-cxx4 package.

This file contains a high-level description of this package's
evolution. Releases are in reverse chronological order (most recent
first).

Note that this file was created and maintained starting with the `netcdf-cxx4 4.3.0 release`.

## netCDF-CXX4 4.3.2 TBD

## netCDF-CXX4 v4.3.1 September 11, 2019

### Requirements

* netCDF-C 4.6.0 or greater

### Changes

* [Enhancement] Added cmake support to distribution files created by `make dist`.

* [Bug Fix] Added `ncFile::create()`, also added a new `open` function
  and constructor to allow for more flexibility when opening a file.
  See [GitHub #55](Unidata/netcdf-cxx4#55)
  for more information.

* [Enhancement] Addressed an issue reported with `Intel Compilers
  17.0.0`. See [GitHub
  #41](Unidata/netcdf-cxx4#41) for more
  information.

* [Enhancement] Updated how `configure` determines information about
  the existing netCDF-C install.  See [GitHub pull request
  #39](Unidata/netcdf-cxx4#39) for more
  information.

* Corrected an issue where cmake-based builds weren't generating
  `ncxx4-config`.  See [GitHub pull request
  #37](Unidata/netcdf-cxx4#37) for more
  information.


## netcdf-cxx4 v4.3.0 released May 13, 2016

* Fixed an issue where the tests were failing silently, and the
  underlying `NcType` class could not properly determine the type name
  or type size reliably. See [GitHub issue
  #30](Unidata/netcdf-cxx4#30) for more
  information.

* Changed `NCXX_ENABLE_DOXYGEN` option to an easier-to-remember `ENABLE_DOXYGEN`.

* Added `--enable-doxygen`, `-DNCXX_ENABLE_DOXYGEN=ON` options to
  allow generation of netCDF-CXX4 documentation via doxygen using
  either `configure` or `cmake`, respectively.

* Added `netcdf-cxx4` to the [Coverity Scan
  Dashboard](https://scan.coverity.com/projects/unidata-netcdf-cxx4?tab=overview).

* Added `open` and `close` methods for NcFile.  See [Github Pull
  Request #18](Unidata/netcdf-cxx4#18) for
  more information.

* Added `netcdf-cxx4` to travis-ci.org.  See
  [https://travis-ci.org/Unidata/netcdf-cxx4](https://travis-ci.org/Unidata/netcdf-cxx4)
  for more details.

* Added `NcCompoundType` methods `getMemberName` and `getMemberIndex`.
  See [Pull Request
  #19](Unidata/netcdf-cxx4#19) for more
  details.

* Added  `cmake` support  to  `netcdf-cxx4`, which  will  allow us  to
  create a  `CDash` continuous integration dashboard  similar to those
  created for the `netcdf-c` and `netcdf-fortran` projects.

* Added a `travis-ci` configuration file, `.travis.yml`.

* Created `RELEASE_NOTES.md`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@WardF WardF

Labels
area/build/all type/enhancement
Projects
None yet
Milestone
4.3.2
Development

No branches or pull requests
3 participants
@DennisHeimbigner @bartvstratum @WardF