Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Token list page not resolving ENS address #115

Open
Rachel-Eichenberger opened this issue Mar 29, 2022 · 5 comments
Open

Token list page not resolving ENS address #115

Rachel-Eichenberger opened this issue Mar 29, 2022 · 5 comments

Comments

@Rachel-Eichenberger
Copy link

I verified json schema
can import on uniswap UI, but fails to load on tokenlists.org
tokenlist.tkr.eth
https://bafybeiasb3nnwwaigkqrhs4z7ac2ygulgeb3v352fahhdwqkf7mpntkgty.ipfs.dweb.link/

image

@doplur
Copy link

doplur commented Mar 29, 2022

See a slightly updated version at: list.tkn.eth or https://list.tkn.eth.limo/

@doplur
Copy link

doplur commented Mar 29, 2022

It appears that there's a CORS issue with the Uniswap cloudflare worker that's serving ENS data:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://wispy-bird-88a7.uniswap.workers.dev/?url=http://list.tkn.eth.link. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 409.

@Rachel-Eichenberger
Copy link
Author

It appears that there's a CORS issue with the Uniswap cloudflare worker that's serving ENS data:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://wispy-bird-88a7.uniswap.workers.dev/?url=http://list.tkn.eth.link. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 409.

@doplur
So I didn't realize this in haste this morning...
This block would be on your end, You might need a dedicated point for your IPFS list.

but if you look other lists with ENS are loading like 1 inch. I will have to close this

@doplur
Copy link

doplur commented Mar 29, 2022

So after parsing down a bit, it would appear that the problem stems from Cloudflare's .link resolver, which is used exclusively by the https://wispy-bird-88a7.uniswap.workers.dev/?url=http://list.tkn.eth.link worker.
By poking the SSL certificate generator in the ENS manager, I was able to get the .link resolver to recover from it's SSL error for this ENS URL. However, eth.link has been notoriously finicky over the last few months, so it may be best to provide multiple gateways with which to resolve ENS data.

@Rachel-Eichenberger
Copy link
Author

Well I'll leave for the team to see, but check this out incase
I know I had to update my cors policy to stop errors
https://github.com/Uniswap/token-lists#authoring-token-lists
image

tiendn pushed a commit to tiendn/token-lists that referenced this issue Jun 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants