-
Notifications
You must be signed in to change notification settings - Fork 45
Logging redesign #1547
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Logging redesign #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f72d71
to
7f97aa5
Compare
3c3a624
to
145e036
Compare
145e036
to
3b88fee
Compare
ae0546c
to
4d86647
Compare
sergeypospelov
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK after fixing remarks, but I didn't dive into details deeply. I guess, you need to update docs.
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt
Outdated
Show resolved
Hide resolved
...instrumentation/src/main/kotlin/org/utbot/instrumentation/process/InstrumentedProcessMain.kt
Show resolved
Hide resolved
utbot-instrumentation/src/main/kotlin/org/utbot/instrumentation/ConcreteExecutor.kt
Outdated
Show resolved
Hide resolved
4d86647
to
5eac028
Compare
9eb68e0
to
c54dc3b
Compare
sergeypospelov
approved these changes
Jan 31, 2023
@Domonion Please add logging of Summarization phase: started - ended. |
b8ae7bb
to
2892c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGNP2m
utbot-maven/src/main/kotlin/org/utbot/maven/plugin/GenerateTestsAndSarifReportMojo.kt
Show resolved
Hide resolved
utbot-rd/src/main/kotlin/org/utbot/rd/loggers/UtRdRemoteLogger.kt
Outdated
Show resolved
Hide resolved
utbot-summary/src/main/kotlin/org/utbot/summary/Summarization.kt
Outdated
Show resolved
Hide resolved
sergeypospelov
approved these changes
Feb 8, 2023
b2b4df5
to
c96c830
Compare
EgorkaKulikov
approved these changes
Feb 8, 2023
Complete logs redesign: 1. Added Logger model to rd. 2. InstrumentedProcess is now sending all logs to EngineProcess, which then writes to its own file. 3. Removed UtSettings.instrumentedProcessLogLevel 4. Auxiliary log functions 5. UtRdLoggers redesigned to have the same logging pattern 6. From now log4j2.xml is responsible for instrumentation process log configuration 7. Added summarization start/end log notifications and instrumented process starting messages. 8. Design doc for logs, clarifying comments and refactoring. 9. Changed `bracket` to `logMeasure`. its signature from plain string message to lambda to remove extra interpolation when message log level is not supported/
c96c830
to
719262f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1122
Type of Change