Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use coverage flags to distinguish between runs #261

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Feb 6, 2025

Currently, we run separate coverage jobs for the different software versions. We run unit and integration tests for

  • The lowest supported CB3 version with a UR5 (Currently 3.14.3)
  • The lowest suppoted PolyScope 5 version with a UR5e (Currently 5.9.4)
  • The latest PolyScope 5 version with a UR20

All of these gather coverage data, but take different branches in the code due to version-dependent execution. As we generate and upload coverage data for all of them, coverage data varies slightly. This approach uses individual flags for each matrix entry. I am not 100% sure whether this does what we want, but I want to give it a try.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (2c12bee) to head (4b56569).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   71.71%   73.45%   +1.74%     
==========================================
  Files          71       76       +5     
  Lines        2786     2969     +183     
  Branches      353      379      +26     
==========================================
+ Hits         1998     2181     +183     
+ Misses        596      588       -8     
- Partials      192      200       +8     
Flag Coverage Δ
ur20-latest 72.00% <ø> (?)
ur5-3.14.3 72.60% <ø> (?)
ur5e-5.9.4 72.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex marked this pull request as ready for review February 6, 2025 10:49
@urfeex urfeex requested a review from a team February 6, 2025 10:59
Copy link
Member

@urrsk urrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@urfeex urfeex merged commit d348df3 into UniversalRobots:master Feb 6, 2025
20 of 23 checks passed
@urfeex urfeex deleted the coverage_flags branch February 6, 2025 12:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants