Fix DashboardClient load program from subdir #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a program from an absolute path or a subdirectory instead of a file being directly in /programs (or /ursim/programs in the case of URSim) the check "programState" will only return the filename without the path while we compare it against the path that was requested to load. However, that second check should not be necessary, as the "load" call will already make sure that the program is loading correctly.
urfeex
changed the title
|
The test failures indicate that not waiting for program state stopped can cause consecutive |
We load the program, which will fail if the program is not found or the requested file does not contain a valid program. Afterwards, we wait until the program state is stopped with a program named the same as the requested program. We cannot check the full file path here, but the important thing is that the program state is stopped.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 73.41% 73.54% +0.13%
==========================================
Files 80 80
Lines 3182 3183 +1
Branches 398 398
==========================================
+ Hits 2336 2341 +5
+ Misses 628 623 -5
- Partials 218 219 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SarveshMalladi
approved these changes
Feb 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268
Drop checking programState when loading a program
When loading a program from an absolute path or a subdirectory instead
of a file being directly in /programs (or /ursim/programs in the case of
URSim) the check "programState" will only return the filename without
the path while we compare it against the path that was requested to
load.
However, that second check should not be necessary, as the "load" call
will already make sure that the program is loading correctly.