issue38 Resolve numpy deprecation warnings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From v2, `__array_wrap__` needs `return_scalar` argument. Implemented with a check for numpy version for backwards compatibility to numpy v1. Looks like this will also be deprecated in the future, so this is a bit of a hack, but it will all change if we change to `xarray` anyway.
```
tests/test__signal.py: 319 warnings
/Users/mitch/Documents/GitHub/acoustic-toolbox/.venv/lib/python3.12/site-packages/scipy/signal/_filter_design.py:3001: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
bw = float(bw)
```
happens when we do `frequencies.lower` on a single frequency/OctaveBand value (e.g. `frequencies[0].lower` or `bands.lower`). Since `Frequencies` applies `np.asarray(lower)` by default, we end up with `np.array([<float>])`. Whereas if `frequencies.lower[0]` was used, it would be fine, since that would extract a single float value from the array.
MitchellAcoustics
changed the title
MitchellAcoustics
changed the title
|
Closes #38 by resolving numpy deprecation warnings related to |
mkdocs-jupyter or pandoc seem unhappy about the mkdocstrings include section having an unclosed div `:::`. See danielfrg/mkdocs-jupyter#231 (comment)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
happens when we do
frequencies.loweron a single frequency/OctaveBand value (e.g.frequencies[0].lowerorbands.lower). SinceFrequenciesappliesnp.asarray(lower)by default, we end up withnp.array([<float>]). Whereas iffrequencies.lower[0]was used, it would be fine, since that would extract a single float value from the array.