bug: don't set default "requests" in Unleash Edge chart values.yaml #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Setting up default "requests" makes it impossible to omit certain portions of "requests" in local
values.yaml
file, e.g. not settingresources.limits.cpu
is impossible. For more information see #121Comment taken from Unleash template to be consistent:
helm-charts/charts/unleash/values.yaml
Lines 193 to 198 in 4cd3a4a
Closes #121