Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug: don't set default "requests" in Unleash Edge chart values.yaml #122

Merged

Conversation

mbarczyk
Copy link
Contributor

About the changes

Setting up default "requests" makes it impossible to omit certain portions of "requests" in local values.yaml file, e.g. not setting resources.limits.cpu is impossible. For more information see #121

Comment taken from Unleash template to be consistent:

resources:
{}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.

Closes #121

setting up default "requests" makes it impossible to omit certain portions of "requests"
in local values.yaml file, e.g. not setting resources.limits.cpu is impossible
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to update this. I will get it merged today, could I trouble you to bump the Chart version so merging this automatically releases the new version and cause our CI pipeline to run green?

@chriswk chriswk self-assigned this Dec 21, 2023
@chriswk
Copy link
Member

chriswk commented Dec 21, 2023

So, the lint fail here is due to the chart version not being updated. We're currently at 2.2.2, so if you bump it to 2.2.3 we should be golden.

@mbarczyk
Copy link
Contributor Author

@chriswk Done. Thank you for looking into it.

@chriswk
Copy link
Member

chriswk commented Dec 21, 2023

Thank you. Merging :)

@chriswk chriswk merged commit 4fa860d into Unleash:main Dec 21, 2023
4 of 8 checks passed
@mbarczyk mbarczyk deleted the mbarczyk/unleash-edge-remove-default-requests branch December 21, 2023 12:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unleash Edge should not set default resources
3 participants