Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add password with PDF files #3721

Merged
merged 14 commits into from
Feb 11, 2025

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Oct 15, 2024

Add password with PDF files
Must be combined with PR 392 in unstructured-inference

@pprados pprados marked this pull request as ready for review October 15, 2024 12:20
@pprados
Copy link
Contributor Author

pprados commented Oct 24, 2024

@plutasnyy can you activate the revue process ?

@plutasnyy
Copy link
Contributor

Sure! Could you add some unit tests? Ideally some PDF with password that is not extractable with current main code.

Please also bump the __version__ and changelog.md you see example in other PRs for example https://github.com/Unstructured-IO/unstructured/pull/3734/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR1

@pprados
Copy link
Contributor Author

pprados commented Oct 24, 2024

@plutasnyy Done. I add TU.

@pprados
Copy link
Contributor Author

pprados commented Oct 25, 2024

@plutasnyy can you test again ?

@pprados
Copy link
Contributor Author

pprados commented Nov 25, 2024

@plutasnyy, can you revue the code ?

@pprados
Copy link
Contributor Author

pprados commented Dec 9, 2024

@cragwolfe or @plutasnyy

Can you approval these workflow ?

@Coniferish
Copy link
Contributor

Hi @pprados! Thanks for making this contribution and following up with us. I have some other issues I'm working on right now, but intend to take a look at these changes later this week.

@pprados
Copy link
Contributor Author

pprados commented Jan 15, 2025

Super ! I will rebase my PR quickly

@pprados
Copy link
Contributor Author

pprados commented Jan 15, 2025

May be can approve this PR, like this I can verify that the PR passes the CI/CD. Otherwise, you must validate each modification I publish.

@pprados
Copy link
Contributor Author

pprados commented Jan 20, 2025

@plutasnyy
This PR on unstructured-inference must be accepted jointly with this one.
The fist in unstructured-inference, then, this one.

@Coniferish
Copy link
Contributor

Coniferish commented Jan 20, 2025

@pprados, I already created a PR in unstructured-inference with your changes and one here in unstructured (see my comment there). I just need someone from the team to approve it and we're all set. Today is a holiday, so people aren't necessarily online today. I'll get this all taken care of tomorrow, though!

Coniferish added a commit to Unstructured-IO/unstructured-inference that referenced this pull request Jan 30, 2025
Add password with PDF files.
Must be combined with [PR 3721 in
unstructured](Unstructured-IO/unstructured#3721)

---------

Co-authored-by: John J <43506685+Coniferish@users.noreply.github.com>
@pprados
Copy link
Contributor Author

pprados commented Jan 31, 2025

@Coniferish
The PR 392 is merged.
But I have to wait for a version to be published in Pypi before making the changes here.
If you can let me know, I'll get back to you as soon as possible and take over this PR accordingly.

@pprados
Copy link
Contributor Author

pprados commented Feb 3, 2025

@Coniferish
Do you know when a new version of unstructured-inference will be released? Without it, I don’t know how to update the PR due to the cross-dependencies between the two projects.

@Coniferish
Copy link
Contributor

@pprados I do not, but I'll see if I can get it updated this week.

@pprados
Copy link
Contributor Author

pprados commented Feb 4, 2025

@Coniferish and @christinestraub
Normally, this is correct if you use unstructured-inference 0.8.7

@Coniferish
Copy link
Contributor

Coniferish commented Feb 4, 2025

Normally, this is correct if you use unstructured-inference 0.8.7

@pprados I'm not understanding this comment. Can you clarify?

@pprados pprados force-pushed the pprados/fix_password branch from 6c1a98b to 734240b Compare February 5, 2025 10:12
@pprados
Copy link
Contributor Author

pprados commented Feb 6, 2025

@Coniferish
Can you review the code ?

@pprados
Copy link
Contributor Author

pprados commented Feb 6, 2025

@Coniferish I will fix

@pprados
Copy link
Contributor Author

pprados commented Feb 6, 2025

@Coniferish It's fixed. Can you restart the CI/CD ?

@pprados
Copy link
Contributor Author

pprados commented Feb 7, 2025

@Coniferish can you revue the code ? thanks

@Coniferish
Copy link
Contributor

Coniferish commented Feb 7, 2025

@pprados, like in the other repo, you can run make check, make tidy, and make test to run linting checks and tests locally before you push changes

@pprados
Copy link
Contributor Author

pprados commented Feb 8, 2025

@Coniferish
Done

@pprados
Copy link
Contributor Author

pprados commented Feb 10, 2025

@Coniferish
Can you revue ?
Thanks

@pprados
Copy link
Contributor Author

pprados commented Feb 11, 2025

@Coniferish
The extra-pdf-image.in must be use unstructured-inference==0.8.7.

It's fixed now

Co-authored-by: John J <43506685+Coniferish@users.noreply.github.com>
@pprados
Copy link
Contributor Author

pprados commented Feb 11, 2025

@Coniferish done.

Copy link
Contributor

@Coniferish Coniferish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pprados! I know there was a lot of back-and-forth, but any future contributions should go more smoothly now that you're familiar with our checks

@Coniferish Coniferish added this pull request to the merge queue Feb 11, 2025
Merged via the queue into Unstructured-IO:main with commit b521bce Feb 11, 2025
41 checks passed
temp-adelyn pushed a commit to temp-adelyn/unstructured that referenced this pull request Mar 3, 2025
Add password with PDF files
Must be combined with [PR 392 in
unstructured-inference](Unstructured-IO/unstructured-inference#392)

---------

Co-authored-by: John J <43506685+Coniferish@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants