Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Plenario Explorer: (Eventually) Integrate user and admin pages #361

Closed
HeyZoos opened this issue Jul 16, 2018 · 2 comments
Closed

Plenario Explorer: (Eventually) Integrate user and admin pages #361

HeyZoos opened this issue Jul 16, 2018 · 2 comments
Assignees
@brlodi @HeyZoos
Labels
Blocked Tasks that are unable to be completed. RFC Requests for Comment

Comments

@HeyZoos
Copy link
Collaborator

HeyZoos commented Jul 16, 2018 •
edited by vforgione
Loading

Bring them under vue, as separate routes under the vue router as opposed to distinct phoenix routes.

Story #373
@vforgione vforgione added RFC Requests for Comment and removed blocked labels Jul 19, 2018
@vforgione
Copy link
Member

Wait, does this come with the implicit intention to refactor all the controllers/views to return JSON only, and make the consumer apps and admin a stand alone app?

@vforgione vforgione added the Blocked Tasks that are unable to be completed. label Jul 19, 2018
@brlodi
Copy link
Collaborator

brlodi commented Jul 19, 2018

All this necessarily entails is combining the various table views and forms from the current Phoenix tree into a single page application. In practice many of those endpoints would likely be modified to return JSON.

vforgione pushed a commit that referenced this issue Nov 14, 2018
Toward a sane internal API and Socrata native ingests
ebf36d7 
The internal API was getting really nasty -- we had a bunch of one off
functions that clashed in arity (positional arguments, matches, guards,
options ...).

The web application was also a disaster -- originally I thought it would
make it easier to keep the web, admin and API separate in subapps,
but that ended up making things that much more difficult.

Then that leaves the elephant in the room: Socrata. We've always relied
on them and all of their awful decisions. The changes here in remove
some of the terrible things about Socrata integration and makes
ingesting their data sets a little cleaner.

Breaking Changes:

- total revision of the migrations
- entirely removed the `UserAdminMessage` schema
- entirely removes all the outstanding ETL job stuff
- entirely removes charts -- that was a really stupid idea
- entirely removes exports -- again just a stupid idea
- totally new ingest pipeline
- slimmed down the API (still needs some work0

Closes #235
Closes #340
Closes #360
Closes #361
@vforgione vforgione mentioned this issue Nov 14, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@brlodi brlodi

@HeyZoos HeyZoos

Labels
Blocked Tasks that are unable to be completed. RFC Requests for Comment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brlodi @vforgione @HeyZoos