Updated Data Set Export #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't really have all that great of an export strategy anymore (we've made a lot of changes to our IO workers without giving any love to the export process), it just makes sense at the moment to open a blank tab and send the user to the source document. I've updated the name of the link to _Download a Copy_ rather than exporting to make it not seem like the users are going to just get a view of the data set that matches their query -- the ideal export functionality. This still needs to fixed soon, but as we are rapidly approaching release I don't want to screw around with big stuff like this. Updates #371
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't really have all that great of an export strategy anymore
(we've made a lot of changes to our IO workers without giving any love
to the export process), it just makes sense at the moment to open a
blank tab and send the user to the source document.
I've updated the name of the link to Download a Copy rather than
exporting to make it not seem like the users are going to just get a
view of the data set that matches their query -- the ideal export
functionality.
This still needs to fixed soon, but as we are rapidly approaching
release I don't want to screw around with big stuff like this.
Updates #371