Ignore incomplete device info when retrieving devices with paths #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes?? 😉 |
UrielCh
reviewed
Nov 7, 2024
| /** | ||
| * adb device starts | ||
| */ | ||
| export type DeviceType = 'emulator' | 'device' | 'offline' | 'unauthorized' | 'recovery'; | ||
| export type DeviceType = typeof deviceTypes[number]; |
|
Released |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users can retrieve a list of devices using
client.listDevicesWithPaths(). Internally, this method parses ADB output which it assumes to be of the form:If
client.listDevicesWithPaths()is called immediately after a new device is connected, that device may be inauthorizingstate which will cause an exception because it takes the form:Solution
Update the string parsing logic to ignore unsupported data.