Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added types related to Library and Patent Classifications #1817

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Feb 27, 2023

Description

Added types and testing for common library classification standards like Dewey Decimal and Library of Congress Subclasses

(issue: #1816 )
(issue: #1819)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Implemented internal Jest tests DeweyDecimal, LCCSubclass, and IPCPatent
  • Tested in Apollo Server Sandbox

Test Environment:

  • OS: Windows 10 Build 19044
  • GraphQL Scalars Version: Latest
  • NodeJS: 18.12.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (unsure what this means)

@cmhhelgeson cmhhelgeson marked this pull request as ready for review February 28, 2023 21:39
@cmhhelgeson cmhhelgeson changed the title Added types related to common library classifications Added types related to Library and Patent Classifications Mar 1, 2023
@ardatan ardatan merged commit 39e1890 into Urigo:master Mar 24, 2023
@theguild-bot theguild-bot mentioned this pull request Apr 24, 2023
37 tasks
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
36 tasks
@theguild-bot theguild-bot mentioned this pull request Feb 5, 2024
36 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants