181937962 share excitement #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
androidmaven
commented
Apr 25, 2022
•
androidmaven
commented
- Match pivotal story
alexosugo
suggested changes
Apr 27, 2022
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| isFullScreen = requireArguments().getBoolean(IS_FULLSCREEN) | ||
| if (isFullScreen) setFullScreen() | ||
| setFullScreen() |
There was a problem hiding this comment.
If transaction details will always be shown as full screen, let's convert this to a proper fragment. It can be simplified to remove unnecessary code.
davkutalek
requested changes
May 4, 2022
There was a problem hiding this comment.
This looks fine codewise. You need to get approval from marketing/graphics for something like this - its a pretty big statement. Also I don't really think its worth the size, looks like it would add ~350KB with just the one gif. But ask marketing what they want to show.
|
Thanks, reverting the codebase to match actual spec. Will request for design thoughts on GIFs as a follow up item. |
androidmaven
force-pushed
the
181937962-shareExcitement
branch
from
cfa6487 to
94227cb
Compare
androidmaven
force-pushed
the
181937962-shareExcitement
branch
from
94227cb to
1cc623f
Compare
alexosugo
approved these changes
May 20, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.