181512365 airtime bonus #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexosugo
commented
May 17, 2022
alexosugo
commented
- Adds support for promo channels (bonus airtime)
- Minor UI fixes and improvements.
…n from channel list
| import kotlinx.coroutines.launch | ||
| import timber.log.Timber | ||
|
|
||
| class BonusViewModel(val repo: BonusRepo, private val dbRepo: DatabaseRepo) : ViewModel() { |
There was a problem hiding this comment.
Really like your code style and naming
| import kotlinx.coroutines.launch | ||
| import timber.log.Timber | ||
|
|
||
| class BonusViewModel(val repo: BonusRepo, private val dbRepo: DatabaseRepo) : ViewModel() { |
There was a problem hiding this comment.
Really like your code style.
Comment on lines
+80
to
90
| fun ImageView.loadImage(fragment: Fragment, url: String) = GlideApp.with(fragment) | ||
| .load(url) | ||
| .placeholder(R.drawable.icon_bg_circle) | ||
| .circleCrop() | ||
| .into(imageView) | ||
| .override(100) | ||
| .into(this) | ||
|
|
||
| fun loadImage(context: Context, url: String, imageView: ImageView) = GlideApp.with(context) | ||
| fun ImageView.loadImage(context: Context, url: String) = GlideApp.with(context) | ||
| .load(url) | ||
| .placeholder(R.drawable.icon_bg_circle) | ||
| .circleCrop() |
Comment on lines
+80
to
90
| fun ImageView.loadImage(fragment: Fragment, url: String) = GlideApp.with(fragment) | ||
| .load(url) | ||
| .placeholder(R.drawable.icon_bg_circle) | ||
| .circleCrop() | ||
| .into(imageView) | ||
| .override(100) | ||
| .into(this) | ||
|
|
||
| fun loadImage(context: Context, url: String, imageView: ImageView) = GlideApp.with(context) | ||
| fun ImageView.loadImage(context: Context, url: String) = GlideApp.with(context) | ||
| .load(url) | ||
| .placeholder(R.drawable.icon_bg_circle) | ||
| .circleCrop() |
| app:layout_constraintEnd_toStartOf="@id/icon" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/title" | ||
| tools:text="Get 8% bonus when you buy airtime with Stax." /> |
There was a problem hiding this comment.
Minor, but maybe to use a string resource.
| app:layout_constraintEnd_toStartOf="@id/icon" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/title" | ||
| tools:text="Get 8% bonus when you buy airtime with Stax." /> |
There was a problem hiding this comment.
Minor, but maybe to use a string resource.
|
|
||
| val hniList = mutableSetOf<String>() | ||
| bonusChannels.forEach { channel -> | ||
| channel.hniList.split(",").forEach { |
There was a problem hiding this comment.
I understand what this is, but can we split have this in its own function, and use a declarative name so that it's easier to understand what's going on.
|
|
||
| val hniList = mutableSetOf<String>() | ||
| bonusChannels.forEach { channel -> | ||
| channel.hniList.split(",").forEach { |
There was a problem hiding this comment.
I understand what this is, but can we split have this in its own function, and use a declarative name so that it's easier to understand what's going on.
androidmaven
approved these changes
May 17, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.