Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP - Collection map type implementation #688

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Dec 1, 2023

This is a work in progress.

Closes #241

This PR adds the implementation of a collection variable map type for bar plot markers.

Current status of work:

  • Some more refactoring to make marker configuration more generic
  • Implement configuration menu
  • Implement overlay components and marker hooks
  • Move HeaderButtons and related logic to its own component that is called by each maptype plugin. (Ie, remove references to marker config from MapAnalysisImpl.)
  • Need to factor logic out of several react hooks so that they can be used in non-hook contexts. This is a peril of using react hooks, since they are not portable.

@dmfalke dmfalke marked this pull request as draft December 1, 2023 18:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map: Add dedicated collections map type
1 participant