Return \n to end of line in case it's deleted #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it's been quite some time. I am reopening (creating a new one instead since it seems I don't have permission to reopen PRs here) #197.
One possible way to resolve #193.
lsp-mode in emacs sometimes tries to edit something past end of line if other conditions are met. Specifically, the template system coming with vhdl-mode seems to trigger this behavior. This removes \n from one of the lines, making rust_hdl contents and actual file contents different.
I have added a unit test to go past the end of line. It indeed fails without the lines I added, and works with them. I also found a bug in my code thanks to running the unit tests. The last line had \n added as well, although it shouldn't. I added a condition for that.
If you know of a better way to handle this, let me know, I could try to implement that instead. I am not very knowledgeable of rust_hdl codebase, so there might be some obvious oversights.